linux-kernel - Re: [PATCH] usb: musb: ux500: optimize DMA callback routine

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 8 Aug 2011 13:01:06 +0300
From:	Felipe Balbi <balbi@...com>
To:	Per Forlin <per.forlin@...aro.org>
Cc:	Felipe Balbi <balbi@...com>, Greg Kroah-Hartman <gregkh@...e.de>,
	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
	linaro-dev@...ts.linaro.org,
	Mian Yousaf KAUKAB <mian.yousaf.kaukab@...ricsson.com>
Subject: Re: [PATCH] usb: musb: ux500: optimize DMA callback routine

Hi,

On Mon, Aug 08, 2011 at 10:32:38AM +0200, Per Forlin wrote:

[snip]

> -/* Work function invoked from DMA callback to handle rx transfers. */
> -static void ux500_rx_work(struct work_struct *data)
> +void ux500_dma_callback(void *private_data)
>  {
> -	struct ux500_dma_channel *ux500_channel = container_of(data,
> -		struct ux500_dma_channel, channel_work);
> +	struct dma_channel *channel = (struct dma_channel *)private_data;

you don't need to explicitly cast a void pointer, please remove that.

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (491 bytes)