linux-kernel - Re: [PATCH 1/3] platform-drivers-x86: eeepc-laptop: fix wrong test for successful registered led

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 8 Aug 2011 14:17:58 +0200
From:	Corentin Chary <corentin.chary@...il.com>
To:	Axel Lin <axel.lin@...il.com>
Cc:	linux-kernel@...r.kernel.org, Matthew Garrett <mjg@...hat.com>,
	acpi4asus-user@...ts.sourceforge.net,
	platform-driver-x86@...r.kernel.org
Subject: Re: [PATCH 1/3] platform-drivers-x86: eeepc-laptop: fix wrong test
 for successful registered led_classdev

Good catch ! It would be great to have a coccinel script to check that
in scripts/coccinelle/null/.

On Mon, Aug 8, 2011 at 11:14 AM, Axel Lin <axel.lin@...il.com> wrote:
> device_create returns &struct device pointer on success, or ERR_PTR() on error.
> Thus if led_classdev_register fails, led_cdev->dev is always not NULL.
>
> If IS_ERR(eeepc->tpd_led.dev) is ture, it means led_classdev_register fails.
> If (asus->tpd_led.dev) is NULL, it means we call eeepc_led_exit before
> calling led_classdev_register for &eeepc->tpd_led.
>
> We only want to call led_classdev_unregister for sucessfully registered
> led_classdev, then we should check (!IS_ERR_OR_NULL(eeepc->tpd_led.dev)).
>
> Signed-off-by: Axel Lin <axel.lin@...il.com>

Acked-by: Corentin Chary <corentin.chary@...il.com>

> ---
>  drivers/platform/x86/eeepc-laptop.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/platform/x86/eeepc-laptop.c b/drivers/platform/x86/eeepc-laptop.c
> index 1c45d92..29a216a 100644
> --- a/drivers/platform/x86/eeepc-laptop.c
> +++ b/drivers/platform/x86/eeepc-laptop.c
> @@ -568,7 +568,7 @@ static int eeepc_led_init(struct eeepc_laptop *eeepc)
>
>  static void eeepc_led_exit(struct eeepc_laptop *eeepc)
>  {
> -       if (eeepc->tpd_led.dev)
> +       if (!IS_ERR_OR_NULL(eeepc->tpd_led.dev))
>                led_classdev_unregister(&eeepc->tpd_led);
>        if (eeepc->led_workqueue)
>                destroy_workqueue(eeepc->led_workqueue);
> --
> 1.7.4.1
>
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>



-- 
Corentin Chary
http://xf.iksaif.net
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/