linux-kernel - Re: [PATCH] nbd: some trivial improvements

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 8 Aug 2011 10:20:40 -0700
From:	Greg KH <gregkh@...e.de>
To:	Amerigo Wang <amwang@...hat.com>
Cc:	linux-kernel@...r.kernel.org, akpm@...ux-foundation.org,
	Paul Clements <Paul.Clements@...eleye.com>,
	Jiri Kosina <trivial@...nel.org>
Subject: Re: [PATCH] nbd: some trivial improvements

On Mon, Aug 08, 2011 at 05:00:04PM +0800, Amerigo Wang wrote:
> This patch 1) uses task_pid_nr(current) to get the pid of current process,
>  2) replaces sysfs_create_file() with device_create_file(), 3) lower
> the loglevel of an error message.

As you are doing 3 different things, please make this 3 different
patches (remember, one patch per logical thing being done.)

> 
> Cc: Greg Kroah-Hartman <gregkh@...e.de>
> Cc: Paul Clements <Paul.Clements@...eleye.com>
> Signed-off-by: WANG Cong <amwang@...hat.com>
> 
> ---
> diff --git a/drivers/block/nbd.c b/drivers/block/nbd.c
> index f533f33..07cad4b 100644
> --- a/drivers/block/nbd.c
> +++ b/drivers/block/nbd.c
> @@ -405,10 +405,10 @@ static int nbd_do_it(struct nbd_device *lo)
>  
>  	BUG_ON(lo->magic != LO_MAGIC);
>  
> -	lo->pid = current->pid;
> -	ret = sysfs_create_file(&disk_to_dev(lo->disk)->kobj, &pid_attr.attr);
> +	lo->pid = task_pid_nr(current);
> +	ret = device_create_file(disk_to_dev(lo->disk), &pid_attr);
>  	if (ret) {
> -		printk(KERN_ERR "nbd: sysfs_create_file failed!");
> +		printk(KERN_ERR "nbd: device_create_file failed!");

Use dev_err() instead please.

>  		lo->pid = 0;
>  		return ret;
>  	}
> @@ -416,7 +416,7 @@ static int nbd_do_it(struct nbd_device *lo)
>  	while ((req = nbd_read_stat(lo)) != NULL)
>  		nbd_end_request(req);
>  
> -	sysfs_remove_file(&disk_to_dev(lo->disk)->kobj, &pid_attr.attr);
> +	device_remove_file(disk_to_dev(lo->disk), &pid_attr);
>  	lo->pid = 0;
>  	return 0;
>  }
> @@ -745,7 +745,7 @@ static int __init nbd_init(void)
>  	BUILD_BUG_ON(sizeof(struct nbd_request) != 28);
>  
>  	if (max_part < 0) {
> -		printk(KERN_CRIT "nbd: max_part must be >= 0\n");
> +		printk(KERN_ERR "nbd: max_part must be >= 0\n");

Again, dev_err() please.  That properly identifies exactly which device
had problems.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/