linux-kernel - Re: Missing put_cpu() in arch/ia64/sn/kernel/sn2/sn

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 8 Aug 2011 14:37:53 -0700
From:	Tony Luck <tony.luck@...el.com>
To:	Thomas Meyer <thomas@...3r.de>
Cc:	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Jes.Sorensen@...hat.com, Julia Lawall <julia@...u.dk>
Subject: Re: Missing put_cpu() in arch/ia64/sn/kernel/sn2/sn_hwperf.c?

On Mon, Aug 8, 2011 at 11:05 AM, Thomas Meyer <thomas@...3r.de> wrote:
> The function sn_hwperf_op_cpu() seems to miss a corresponding put_cpu().
>
> Or is this done in another function? I didn't find it.

It would be hard to do it elsewhere - this function may not have done
a get_cpu() [in the cpu == SN_HWPERF_ARG_ANY_CPU case].

The logic is a bit tortuous here ... perhaps simpler to split the tests
up.  Does the attached patch look right?

-Tony

View attachment "sn_hwperf_op_cpu.patch" of type "text/x-patch" (777 bytes)