[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Mon, 08 Aug 2011 09:18:29 +0100
From: David Howells <dhowells@...hat.com>
To: Al Viro <viro@...IV.linux.org.uk>,
Linus Torvalds <torvalds@...ux-foundation.org>,
"Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>
Cc: dhowells@...hat.com, linux-kernel@...r.kernel.org
Subject: Re: fix rcu annotations noise in cred.h
Al Viro <viro@...IV.linux.org.uk> wrote:
> #define current_cred() \
> - (current->cred)
> + (*(__force struct cred **)¤t->cred)
No. You've cast away the const. Please don't do that.
Paul: isn't there some better way of doing this using an RCU wrapper macro?
#define current_cred() \
rcu_dereference_protected(current->cred, 1)
Perhaps?
David
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists