linux-kernel - Re: [tip:core/urgent] lockdep: Fix wrong assumption in match_held

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 10 Aug 2011 10:58:45 +0800
From:	Yong Zhang <yong.zhang0@...il.com>
To:	mingo@...hat.com, hpa@...or.com, linux-kernel@...r.kernel.org,
	a.p.zijlstra@...llo.nl, sergey.senozhatsky@...il.com,
	tglx@...utronix.de, mingo@...e.hu
Cc:	linux-tip-commits@...r.kernel.org
Subject: Re: [tip:core/urgent] lockdep: Fix wrong assumption in
 match_held_lock

On Tue, Aug 09, 2011 at 02:30:02PM +0000, tip-bot for Peter Zijlstra wrote:
> Commit-ID:  80e0401e35410a69bfae05b454db8a7187edd6b8
> Gitweb:     http://git.kernel.org/tip/80e0401e35410a69bfae05b454db8a7187edd6b8
> Author:     Peter Zijlstra <a.p.zijlstra@...llo.nl>
> AuthorDate: Fri, 5 Aug 2011 14:26:17 +0200
> Committer:  Ingo Molnar <mingo@...e.hu>
> CommitDate: Tue, 9 Aug 2011 11:57:35 +0200
> 
> lockdep: Fix wrong assumption in match_held_lock
> 
> match_held_lock() was assuming it was being called on a lock class
> that had already seen usage.
> 
> This condition was true for bug-free code using lockdep_assert_held(),
> since you're in fact holding the lock when calling it. However the
> assumption fails the moment you assume the assertion can fail, which
> is the whole point of having the assertion in the first place.
> 
> Anyway, now that there's more lockdep_is_held() users, notably
> __rcu_dereference_check(), its much easier to trigger this since we
> test for a number of locks and we only need to hold any one of them to
> be good.
> 
> Reported-by: Sergey Senozhatsky <sergey.senozhatsky@...il.com>
> Signed-off-by: Peter Zijlstra <a.p.zijlstra@...llo.nl>
> Link: http://lkml.kernel.org/r/1312547787.28695.2.camel@twins

BTW, I can't open this link.

Thanks,
Yong

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/