linux-kernel - Re: [PATCH v2] hwmon: add caseopen detection to w83627ehf driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sat, 13 Aug 2011 00:38:25 +0400
From:	Dmitry Artamonow <mad_soft@...ox.ru>
To:	Guenter Roeck <guenter.roeck@...csson.com>
Cc:	"lm-sensors@...sensors.org" <lm-sensors@...sensors.org>,
	Ian Dobson <i.dobson@...net-ian.com>,
	Jean Delvare <khali@...ux-fr.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] hwmon: add caseopen detection to w83627ehf driver

On 10:46 Thu 11 Aug     , Guenter Roeck wrote:
> Hi Dmitry,
> 
> please consider the changes suggested below.

[...]

> > +static struct sensor_device_attribute sda_caseopen[] = {
> > +	SENSOR_ATTR(intrusion0_alarm, S_IWUSR | S_IRUGO, show_caseopen,
> > +			clear_caseopen, 0),
> > +	SENSOR_ATTR(intrusion1_alarm, S_IWUSR | S_IRUGO, show_caseopen,
> > +			clear_caseopen, 1),
> 
> 	SENSOR_ATTR_2(intrusion0_alarm, S_IWUSR | S_IRUGO,
> 			show_caseopen, clear_caseopen, 0x80, 0x10),
> 	SENSOR_ATTR_2(intrusion1_alarm, S_IWUSR | S_IRUGO,
> 			show_caseopen, clear_caseopen, 0x40, 0x40),
> 

Oh, yeah! That's much neater with SENSOR_ATTR_2 - thanks for suggestion!
I've seen it while looking to other hwmon drivers, but missed the difference
from plain SENSOR_ATTR...

I've incorporated your suggested changes into v3 of the patch - it will follow
this mail.

-- 
Best regards,
Dmitry "MAD" Artamonow

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/