linux-kernel - Re: [RFC PATCH 08/12] gpio/tegra: Add device tree support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 13 Aug 2011 11:49:18 +0200
From:	Belisko Marek <marek.belisko@...il.com>
To:	Stephen Warren <swarren@...dia.com>
Cc:	Grant Likely <grant.likely@...retlab.ca>,
	Colin Cross <ccross@...roid.com>,
	Erik Gilling <konkers@...roid.com>,
	Olof Johansson <olof@...om.net>,
	Russell King <linux@....linux.org.uk>,
	Arnd Bergmann <arnd@...db.de>,
	devicetree-discuss@...ts.ozlabs.org, linux-tegra@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [RFC PATCH 08/12] gpio/tegra: Add device tree support

On Sat, Aug 13, 2011 at 12:54 AM, Stephen Warren <swarren@...dia.com> wrote:
> Signed-off-by: Stephen Warren <swarren@...dia.com>
> ---
>  drivers/gpio/gpio-tegra.c |   31 +++++++++++++++++++++++++++++++
>  1 files changed, 31 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/gpio/gpio-tegra.c b/drivers/gpio/gpio-tegra.c
> index 4da4839..923b413 100644
> --- a/drivers/gpio/gpio-tegra.c
> +++ b/drivers/gpio/gpio-tegra.c
> @@ -326,6 +326,29 @@ static struct irq_chip tegra_gpio_irq_chip = {
>  #endif
>  };
>
> +#ifdef CONFIG_OF
> +static void __init tegra_gpio_probe_dt(struct platform_device *pdev)
> +{
> +       const __be32 *gpios;
> +       u32 gpioslen;
> +       int i;
> +
> +       gpios = of_get_property(pdev->dev.of_node, "nvidia,gpios", &gpioslen);
> +       if (gpios == NULL)
> +               return;
> +
> +       gpioslen /= sizeof(*gpios);
> +       for (i = 0; i < gpioslen; i++, gpios++) {
> +               u32 gpio = be32_to_cpup(gpios);
> +               dev_err(&pdev->dev, "Enabling GPIO %d\n", gpio);
Is really necessary to print all enabled gpio's to console? Also seen
same in pinmux probe.
> +               tegra_gpio_enable(gpio);
> +       }
> +}
> +#else
> +static inline void __init tegra_gpio_probe_dt(struct platform_device *pdev)
> +{
> +}
> +#endif
>
>  /* This lock class tells lockdep that GPIO irqs are in a different
>  * category than their parents, so it won't report false recursion.
> @@ -371,13 +394,21 @@ static int __init tegra_gpio_probe(struct platform_device *pdev)
>                        spin_lock_init(&bank->lvl_lock[j]);
>        }
>
> +       tegra_gpio_probe_dt(pdev);
> +
>        return 0;
>  }
>
> +static struct of_device_id tegra_gpio_of_match[] __devinitdata = {
> +       { .compatible = "nvidia,tegra20-gpio", },
> +       { },
> +};
> +
>  static struct platform_driver tegra_gpio_driver = {
>        .driver         = {
>                .name   = "tegra-gpio",
>                .owner  = THIS_MODULE,
> +               .of_match_table = tegra_gpio_of_match,
>        },
>        .probe          = tegra_gpio_probe,
>  };
> --
> 1.7.0.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
>

regards,

marek

-- 
as simple and primitive as possible
-------------------------------------------------
Marek Belisko - OPEN-NANDRA
Freelance Developer

Ruska Nova Ves 219 | Presov, 08005 Slovak Republic
Tel: +421 915 052 184
skype: marekwhite
icq: 290551086
web: http://open-nandra.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/