linux-kernel - Re: [BUG] Linux 3.0 commit 3627924acf70a broke include/mtd/ubi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 14 Aug 2011 20:03:22 +0200
From:	Stefan Richter <stefanr@...6.in-berlin.de>
To:	Rob Landley <rob@...dley.net>
Cc:	linux-kernel@...r.kernel.org, Artem.Bityutskiy@...ia.com,
	busybox@...ybox.net
Subject: Re: [BUG] Linux 3.0 commit 3627924acf70a broke
 include/mtd/ubi_user.h.

On Aug 14 Rob Landley wrote:
> "make headers_install" copies include/mtd/ubi_user.h to userspace, where
> things like busybox link against it.  With 3.0, building defconfig
> busybox gets this error:
> 
> In file included from miscutils/ubi_tools.c:63:
> /home/landley/aboriginal/aboriginal/build/simple-cross-compiler-i686/bin/../include/mtd/ubi-user.h:329:
> error: conflicting types for '__packed'
> /home/landley/aboriginal/aboriginal/build/simple-cross-compiler-i686/bin/../include/mtd/ubi-user.h:313:
> error: previous declaration of '__packed' was here
> 
> This is due to the Linux 3.0 commit in the title:
> 
>     UBI: use __packed instead of __attribute__((packed))
> 
> This relies on __packed being defined in:
> 
>   include/linux/compiler-gcc.h:
>   #define __packed			__attribute__((packed))
> 
> Which is not exported to userspace.
> 
> I.E. this "cleanup" broke the ability for userspace to use this header,
> even though the header is exported to userspace by headers_install.

As far as I can tell, the __packed or __attribute__((packed))
qualifications are superfluous in include/mtd/ubi-user.h anyway.
-- 
Stefan Richter
-=====-==-== =--- -===-
http://arcgraph.de/sr/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/