lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Date:	Mon, 15 Aug 2011 10:28:18 +0800
From:	Shawn Guo <shawn.guo@...aro.org>
To:	linux-mmc@...r.kernel.org
Cc:	linux-kernel@...r.kernel.org, Chris Ball <cjb@...top.org>,
	Stephen Rothwell <sfr@...b.auug.org.au>, patches@...aro.org,
	Shawn Guo <shawn.guo@...aro.org>
Subject: [PATCH] mmc: sdhci-esdhc-imx: add missing inclusion of linux/module.h

There are following warning and error when compiling the driver.
The patch adds the missing inclusion of linux/module.h to fix them.

drivers/mmc/host/sdhci-esdhc-imx.c:87:1: warning: data definition has no type or storage class
drivers/mmc/host/sdhci-esdhc-imx.c:87:1: warning: type defaults to ‘int’ in declaration of ‘MODULE_DEVICE_TABLE’
drivers/mmc/host/sdhci-esdhc-imx.c:87:1: warning: parameter names (without types) in function declaration
drivers/mmc/host/sdhci-esdhc-imx.c:96:1: warning: data definition has no type or storage class
drivers/mmc/host/sdhci-esdhc-imx.c:96:1: warning: type defaults to ‘int’ in declaration of ‘MODULE_DEVICE_TABLE’
drivers/mmc/host/sdhci-esdhc-imx.c:96:1: warning: parameter names (without types) in function declaration
drivers/mmc/host/sdhci-esdhc-imx.c:563:12: error: ‘THIS_MODULE’ undeclared here (not in a function)
drivers/mmc/host/sdhci-esdhc-imx.c:587:20: error: expected declaration specifiers or ‘...’ before string constant
drivers/mmc/host/sdhci-esdhc-imx.c:587:1: warning: data definition has no type or storage class
drivers/mmc/host/sdhci-esdhc-imx.c:587:1: warning: type defaults to ‘int’ in declaration of ‘MODULE_DESCRIPTION’
drivers/mmc/host/sdhci-esdhc-imx.c:587:20: warning: function declaration isn’t a prototype
drivers/mmc/host/sdhci-esdhc-imx.c:588:15: error: expected declaration specifiers or ‘...’ before string constant
drivers/mmc/host/sdhci-esdhc-imx.c:588:1: warning: data definition has no type or storage class
drivers/mmc/host/sdhci-esdhc-imx.c:588:1: warning: type defaults to ‘int’ in declaration of ‘MODULE_AUTHOR’
drivers/mmc/host/sdhci-esdhc-imx.c:588:15: warning: function declaration isn’t a prototype
drivers/mmc/host/sdhci-esdhc-imx.c:589:16: error: expected declaration specifiers or ‘...’ before string constant
drivers/mmc/host/sdhci-esdhc-imx.c:589:1: warning: data definition has no type or storage class
drivers/mmc/host/sdhci-esdhc-imx.c:589:1: warning: type defaults to ‘int’ in declaration of ‘MODULE_LICENSE’
drivers/mmc/host/sdhci-esdhc-imx.c:589:16: warning: function declaration isn’t a prototype

Signed-off-by: Shawn Guo <shawn.guo@...aro.org>
Cc: Chris Ball <cjb@...top.org>
---
Hi Stephen,

I spot this on linux-next-20110812.

Regards,
Shawn

 drivers/mmc/host/sdhci-esdhc-imx.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/mmc/host/sdhci-esdhc-imx.c b/drivers/mmc/host/sdhci-esdhc-imx.c
index 2a1ba84..4557aa1 100644
--- a/drivers/mmc/host/sdhci-esdhc-imx.c
+++ b/drivers/mmc/host/sdhci-esdhc-imx.c
@@ -16,6 +16,7 @@
 #include <linux/err.h>
 #include <linux/clk.h>
 #include <linux/gpio.h>
+#include <linux/module.h>
 #include <linux/slab.h>
 #include <linux/mmc/host.h>
 #include <linux/mmc/mmc.h>
-- 
1.7.4.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ