linux-kernel - Re: [PATCH 12/41] microblaze: Don't reimplement force

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 17 Aug 2011 15:14:44 +0200
From:	Oleg Nesterov <oleg@...hat.com>
To:	Michal Simek <monstr@...str.eu>
Cc:	Matt Fleming <matt@...sole-pimps.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 12/41] microblaze: Don't reimplement force_sigsegv()

On 08/17, Michal Simek wrote:
>
> Oleg Nesterov wrote:
>> On 08/16, Oleg Nesterov wrote:
>>> This and the next patch seem to have the same problems with the
>>> changelogs as 18 and 19.
>>>
>>> 13-14 looks correct to me...
>>
>> I meant 14-15, sorry for noise
>
> Do you mean that there is
> From: Matt Fleming <matt.fleming@...el.com> ?

Confused... "From" looks correct to me.

The changelog is wrong and should be updated (Matt seems to agree).
This patch fixes the bug, this should be explained. The problem is,
ka points to the copy of sighand->action, the current code is pointless.

> Anyway: I have looked at patches 12-15 and they look good to me.
>
> Acked-by: Michal Simek <monstr@...str.eu>

Assuming the changelog is fixed,

	Acked-by: Oleg Nesterov <oleg@...hat.com>

> If you want to propose 12-15 through my Microblaze tree, please let me know.

Probably this is the best option. Matt, what do you think?

Oleg.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/