linux-kernel - Re: [PATCH] fat: fat16 support maximum 4GB file/vol size as WinXP or 7.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 17 Aug 2011 12:04:14 +0900
From:	OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>
To:	Namjae Jeon <linkinjeon@...il.com>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] fat: fat16 support maximum 4GB file/vol size as WinXP or 7.

Namjae Jeon <linkinjeon@...il.com> writes:

> FAT16 support maximum 4GB vol/file size with 64KB cluster size.
>
> Win NT/XP/7 increased the maximum cluster size to 64KB, and file/vol size increased 4GB also.
> Although increasing, the file size of linux FAT is still limited at 2GB.
> I found that it is limited by sb->maxbytes(0x7fffffff) when partition is formatted by FAT16.
> sb->s_maxbytes in fill_super should be set to 0xffffffff like fat32.
>
> Signed-off-by: Namjae Jeon <linkinjeon@...il.com>

Thanks. I'll apply.

> ---
>  fs/fat/inode.c |    3 +--
>  1 files changed, 1 insertions(+), 2 deletions(-)
>
> diff --git a/fs/fat/inode.c b/fs/fat/inode.c
> index 5942fec..f2dce50 100644
> --- a/fs/fat/inode.c
> +++ b/fs/fat/inode.c
> @@ -1367,6 +1367,7 @@ int fat_fill_super(struct super_block *sb, void *data, int silent, int isvfat,
>  	sbi->free_clusters = -1;	/* Don't know yet */
>  	sbi->free_clus_valid = 0;
>  	sbi->prev_free = FAT_START_ENT;
> +	sb->s_maxbytes = 0xffffffff;
>  
>  	if (!sbi->fat_length && b->fat32_length) {
>  		struct fat_boot_fsinfo *fsinfo;
> @@ -1377,8 +1378,6 @@ int fat_fill_super(struct super_block *sb, void *data, int silent, int isvfat,
>  		sbi->fat_length = le32_to_cpu(b->fat32_length);
>  		sbi->root_cluster = le32_to_cpu(b->root_cluster);
>  
> -		sb->s_maxbytes = 0xffffffff;
> -
>  		/* MC - if info_sector is 0, don't multiply by 0 */
>  		sbi->fsinfo_sector = le16_to_cpu(b->info_sector);
>  		if (sbi->fsinfo_sector == 0)

-- 
OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/