linux-kernel - Re: [PATCH 4/9] Staging: Winbond: Convert C99 style comments in Winbond.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 18 Aug 2011 00:08:21 +0300
From:	Dan Carpenter <error27@...il.com>
To:	Akshay Joshi <me@...hayjoshi.com>
Cc:	Pavel Machek <pavel@....cz>, Greg Kroah-Hartman <gregkh@...e.de>,
	Pekka Enberg <penberg@...nel.org>,
	Karthigan Srinivasan <karthigan.srinivasan2@...il.com>,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 4/9] Staging: Winbond: Convert C99 style comments in
 Winbond.

On Wed, Aug 17, 2011 at 03:17:01PM -0400, Akshay Joshi wrote:
> This updated patch should fix the comment concerns.
> 
> Pekka, I did compile-test it, but it slipped through since the comment
> was followed by another comment and not a line of code.
> 

It compiles correctly, but there is a gcc warning:

  CC [M]  drivers/staging/winbond/mds.o
  In file included from drivers/staging/winbond/wbhal.h:361:0,
		   from drivers/staging/winbond/mds_f.h:4,
		   from drivers/staging/winbond/mds.c:1:
	drivers/staging/winbond/wb35rx_s.h:2:1: warning: "/*" within comment
	drivers/staging/winbond/wb35rx_s.h:3:1: warning: "/*" within comment
	drivers/staging/winbond/wb35rx_s.h:5:1: warning: "/*" within comment

That's with gcc 4.5.1-4.

regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/