| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Thu, 18 Aug 2011 17:15:57 +0200 From: Tejun Heo <tj@...nel.org> To: Jan Beulich <JBeulich@...ell.com> Cc: mingo@...e.hu, stable@...nel.org, tglx@...utronix.de, linux-kernel@...r.kernel.org, hpa@...or.com Subject: Re: [PATCH] i386/bigsmp: eliminate false warnings regarding logical APIC ID mismatches On Thu, Aug 18, 2011 at 04:10:59PM +0100, Jan Beulich wrote: > > Hmmm... the only thing it can break is numa affinity of static percpu > > areas (it doesn't even affect that anymore), which didn't work at all > > on i386 before and keeps to not working for those exotic apic machines > > anyway. Silencing the warnings wouldn't hurt anything at all. If > > you're still concerned that something legitimate might trigger it, > > wouldn't converting WARN_ON() there to printk_once() be enough? That > > doesn't change the behavior at all sans lesser noise. > > That might be reasonable to do, yet I still think that changing what got > produced with by the older APIC driver to what the new one would have > produced when the driver gets changed is more consistent than just > printing something, until the method in question is gone altogether. Sure, either seems fine to me. Please feel free to add my acked-by. Thanks. -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists