linux-kernel - [PATCH 3/4] pm34xx: Warning FIX related to ambiguous else loop

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 19 Aug 2011 17:25:26 +0530
From:	Abhilash K V <abhilash.kv@...com>
To:	<linux-omap@...r.kernel.org>,
	<linux-arm-kernel@...ts.infradead.org>,
	<linux-kernel@...r.kernel.org>
CC:	<tony@...mide.com>, <linux@....linux.org.uk>, <khilman@...com>,
	Vaibhav Hiremath <hvaibhav@...com>,
	Abhilash K V <abhilash.kv@...com>
Subject: [PATCH 3/4] pm34xx: Warning FIX related to ambiguous else loop

From: Vaibhav Hiremath <hvaibhav@...com>

Fixes below warning -

arch/arm/mach-omap2/pm34xx.c:1041: warning:
        suggest explicit braces to avoid ambiguous 'else

Signed-off-by: Vaibhav Hiremath <hvaibhav@...com>
Signed-off-by: Abhilash K V <abhilash.kv@...com>
---
 arch/arm/mach-omap2/pm34xx.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/arch/arm/mach-omap2/pm34xx.c b/arch/arm/mach-omap2/pm34xx.c
index 12af5b9..ab3822b 100644
--- a/arch/arm/mach-omap2/pm34xx.c
+++ b/arch/arm/mach-omap2/pm34xx.c
@@ -856,7 +856,7 @@ void omap_push_sram_idle(void)
 	else
 		_omap_sram_idle = omap_sram_push(omap34xx_cpu_suspend,
 					omap34xx_cpu_suspend_sz);
-	if (omap_type() != OMAP2_DEVICE_TYPE_GP)
+	if (omap_type() != OMAP2_DEVICE_TYPE_GP) {
 		if (cpu_is_omap3505() || cpu_is_omap3517())
 			_omap_save_secure_sram = omap_sram_push(
 					omap3517_save_secure_ram_context,
@@ -865,6 +865,7 @@ void omap_push_sram_idle(void)
 			_omap_save_secure_sram = omap_sram_push(
 					save_secure_ram_context,
 					save_secure_ram_context_sz);
+	}
 }
 
 static void __init pm_errata_configure(void)
-- 
1.7.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/