linux-kernel - Re: [PATCH] backlight: ep93xx_bl: add missing include of linux/module.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 22 Aug 2011 09:55:19 +1000
From:	Ryan Mallon <rmallon@...il.com>
To:	Axel Lin <axel.lin@...il.com>
CC:	linux-kernel@...r.kernel.org,
	H Hartley Sweeten <hsweeten@...ionengravers.com>,
	Richard Purdie <rpurdie@...ys.net>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH] backlight: ep93xx_bl: add missing include of linux/module.h

On 22/08/11 09:39, Ryan Mallon wrote:
> On 22/08/11 00:33, Axel Lin wrote:
>> ep93xx_bl.c uses interfaces from linux/module.h,
>> so it should include that file. This patch fixes below build errors.
>
> Thanks,
>
> Acked-by: Ryan Mallon <rmallon@...il.com>

Retracted. Please see my reply to the ep93xx framebuffer patch.

~Ryan

>
>>    CC [M]  drivers/video/backlight/ep93xx_bl.o
>> drivers/video/backlight/ep93xx_bl.c:138: error: 'THIS_MODULE' 
>> undeclared here (not in a function)
>> drivers/video/backlight/ep93xx_bl.c:158: error: expected declaration 
>> specifiers or '...' before string constant
>> drivers/video/backlight/ep93xx_bl.c:158: warning: data definition has 
>> no type or storage class
>> drivers/video/backlight/ep93xx_bl.c:158: warning: type defaults to 
>> 'int' in declaration of 'MODULE_DESCRIPTION'
>> drivers/video/backlight/ep93xx_bl.c:158: warning: function 
>> declaration isn't a prototype
>> drivers/video/backlight/ep93xx_bl.c:159: error: expected declaration 
>> specifiers or '...' before string constant
>> drivers/video/backlight/ep93xx_bl.c:159: warning: data definition has 
>> no type or storage class
>> drivers/video/backlight/ep93xx_bl.c:159: warning: type defaults to 
>> 'int' in declaration of 'MODULE_AUTHOR'
>> drivers/video/backlight/ep93xx_bl.c:159: warning: function 
>> declaration isn't a prototype
>> drivers/video/backlight/ep93xx_bl.c:160: error: expected declaration 
>> specifiers or '...' before string constant
>> drivers/video/backlight/ep93xx_bl.c:160: warning: data definition has 
>> no type or storage class
>> drivers/video/backlight/ep93xx_bl.c:160: warning: type defaults to 
>> 'int' in declaration of 'MODULE_LICENSE'
>> drivers/video/backlight/ep93xx_bl.c:160: warning: function 
>> declaration isn't a prototype
>> drivers/video/backlight/ep93xx_bl.c:161: error: expected declaration 
>> specifiers or '...' before string constant
>> drivers/video/backlight/ep93xx_bl.c:161: warning: data definition has 
>> no type or storage class
>> drivers/video/backlight/ep93xx_bl.c:161: warning: type defaults to 
>> 'int' in declaration of 'MODULE_ALIAS'
>> drivers/video/backlight/ep93xx_bl.c:161: warning: function 
>> declaration isn't a prototype
>> make[3]: *** [drivers/video/backlight/ep93xx_bl.o] Error 1
>> make[2]: *** [drivers/video/backlight] Error 2
>> make[1]: *** [drivers/video] Error 2
>> make: *** [drivers] Error 2
>>
>> Signed-off-by: Axel Lin<axel.lin@...il.com>
>> ---
>>   drivers/video/backlight/ep93xx_bl.c |    2 +-
>>   1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/drivers/video/backlight/ep93xx_bl.c 
>> b/drivers/video/backlight/ep93xx_bl.c
>> index 9f1e389..b058291 100644
>> --- a/drivers/video/backlight/ep93xx_bl.c
>> +++ b/drivers/video/backlight/ep93xx_bl.c
>> @@ -11,7 +11,7 @@
>>    * BRIGHT, on the Cirrus EP9307, EP9312, and EP9315 processors.
>>    */
>>
>> -
>> +#include<linux/module.h>
>>   #include<linux/platform_device.h>
>>   #include<linux/io.h>
>>   #include<linux/fb.h>
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/