linux-kernel - [PATCH 2/4] kexec: Export compare_ranges() function from firmware

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Sun, 21 Aug 2011 15:52:42 +0200
From:	Daniel Kiper <dkiper@...-space.pl>
To:	konrad.wilk@...cle.com, ian.campbell@...rix.com, vgoyal@...hat.com,
	horms@...ge.net.au, olaf@...fle.de, kexec@...ts.infradead.org,
	xen-devel@...ts.xensource.com, linux-kernel@...r.kernel.org
Subject: [PATCH 2/4] kexec: Export compare_ranges() function from firmware_memmap.c module

Export compare_ranges() function from firmware_memmap.c module.
It is generic function and it could be used by other modules.

Signed-off-by: Daniel Kiper <dkiper@...-space.pl>
---
 kexec/firmware_memmap.c |   14 ++------------
 kexec/firmware_memmap.h |   13 +++++++++++++
 2 files changed, 15 insertions(+), 12 deletions(-)

diff --git a/kexec/firmware_memmap.c b/kexec/firmware_memmap.c
index d8afed5..9598933 100644
--- a/kexec/firmware_memmap.c
+++ b/kexec/firmware_memmap.c
@@ -179,18 +179,8 @@ static int parse_memmap_entry(const char *entry, struct memory_range *range)
 	return 0;
 }
 
-/**
- * Compares two memory ranges according to their start address. This function
- * can be used with qsort() as @c compar function.
- *
- * @param[in] first a pointer to the first memory range
- * @param[in] second a pointer to the second memory range
- * @return 0 if @p first and @p second have the same start address,
- *         a value less then 0 if the start address of @p first is less than
- *         the start address of @p second, and a value greater than 0 if
- *         the opposite is in case.
- */
-static int compare_ranges(const void *first, const void *second)
+/* documentation: firmware_memmap.h */
+int compare_ranges(const void *first, const void *second)
 {
 	const struct memory_range *first_range = first;
 	const struct memory_range *second_range = second;
diff --git a/kexec/firmware_memmap.h b/kexec/firmware_memmap.h
index adb03c3..eac0ddb 100644
--- a/kexec/firmware_memmap.h
+++ b/kexec/firmware_memmap.h
@@ -39,6 +39,19 @@
  */
 
 /**
+ * Compares two memory ranges according to their start address. This function
+ * can be used with qsort() as @c compar function.
+ *
+ * @param[in] first a pointer to the first memory range
+ * @param[in] second a pointer to the second memory range
+ * @return 0 if @p first and @p second have the same start address,
+ *         a value less then 0 if the start address of @p first is less than
+ *         the start address of @p second, and a value greater than 0 if
+ *         the opposite is in case.
+ */
+int compare_ranges(const void *first, const void *second);
+
+/**
  * Checks if the kernel provides the /sys/firmware/memmap interface.
  * It makes sense to use that function in advance before calling
  * get_firmware_memmap_ranges() because the latter function prints an error
-- 
1.5.6.5
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/