linux-kernel - Re: [PATCH v2] drivers:uio:change the goto label to consistent with others

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 22 Aug 2011 13:30:04 +0200
From:	"Hans J. Koch" <hjk@...sjkoch.de>
To:	Wanlong Gao <wanlong.gao@...il.com>
Cc:	linux-kernel@...r.kernel.org, hjk@...sjkoch.de, gregkh@...e.de,
	Wanlong Gao <gaowanlong@...fujitsu.com>
Subject: Re: [PATCH v2] drivers:uio:change the goto label to consistent with
 others

On Sat, Aug 20, 2011 at 12:12:08PM +0800, Wanlong Gao wrote:
> From: Wanlong Gao <gaowanlong@...fujitsu.com>
> 
> sorry for v1's typo mistake.
> Thanks
> 
> Remove one *goto* label in uio.c.

Nice, that makes it a bit cleaner.

Thanks,
Hans

> 
> Signed-off-by: Wanlong Gao <gaowanlong@...fujitsu.com>

Signed-off-by: "Hans J. Koch" <hjk@...sjkoch.de>

> ---
>  drivers/uio/uio.c |    7 +++----
>  1 files changed, 3 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/uio/uio.c b/drivers/uio/uio.c
> index d2efe82..c89f12a 100644
> --- a/drivers/uio/uio.c
> +++ b/drivers/uio/uio.c
> @@ -750,14 +750,13 @@ static int uio_major_init(void)
>  
>  	uio_major = MAJOR(uio_dev);
>  	uio_cdev = cdev;
> -	result = 0;
> -out:
> -	return result;
> +	return 0;
>  out_put:
>  	kobject_put(&cdev->kobj);
>  out_unregister:
>  	unregister_chrdev_region(uio_dev, UIO_MAX_DEVICES);
> -	goto out;
> +out:
> +	return result;
>  }
>  
>  static void uio_major_cleanup(void)
> -- 
> 1.7.4.1
> 
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/