linux-kernel - RE: [PATCH] Input: adp5588-keys

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 25 Aug 2011 11:43:53 +0100
From:	"Hennerich, Michael" <Michael.Hennerich@...log.com>
To:	Axel Lin <axel.lin@...il.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
CC:	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	"device-drivers-devel@...ckfin.uclinux.org" 
	<device-drivers-devel@...ckfin.uclinux.org>,
	"linux-input@...r.kernel.org" <linux-input@...r.kernel.org>
Subject: RE: [PATCH] Input: adp5588-keys - remove incorrect modalias

Axel Lin wrote on 2011-08-25:
> From 2b642fd34e59291764f5149f083d84760d8b41b2 Mon Sep 17 00:00:00 2001
> From: Axel Lin <axel.lin@...il.com>
> Date: Thu, 25 Aug 2011 18:26:56 +0800
> Subject: [PATCH] Input: adp5588-keys - remove incorrect modalias
>
> For i2c drivers, we should use "i2c:" prefix for modalias.
> MODULE_DEVICE_TABLE will setup the modulalias for us,
> thus adding a MODULE_ALIAS here seems redundant.
>
> Signed-off-by: Axel Lin <axel.lin@...il.com>

Acked-by: Michael Hennerich <michael.hennerich@...log.com>

> ---
>  drivers/input/keyboard/adp5588-keys.c |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
> diff --git a/drivers/input/keyboard/adp5588-keys.c
> b/drivers/input/keyboard/adp5588-keys.c index 7b404e54..e34eeb8 100644
> --- a/drivers/input/keyboard/adp5588-keys.c +++
> b/drivers/input/keyboard/adp5588-keys.c @@ -668,4 +668,3 @@
> module_exit(adp5588_exit);
>  MODULE_LICENSE("GPL");
>  MODULE_AUTHOR("Michael Hennerich <hennerich@...ckfin.uclinux.org>");
>  MODULE_DESCRIPTION("ADP5588/87 Keypad driver");
> -MODULE_ALIAS("platform:adp5588-keys");

Greetings,
Michael

--
Analog Devices GmbH      Wilhelm-Wagenfeld-Str. 6      80807 Muenchen
Sitz der Gesellschaft: Muenchen; Registergericht: Muenchen HRB 40368;
Geschaeftsfuehrer:Dr.Carsten Suckrow, Thomas Wessel, William A. Martin, Margaret Seif