linux-kernel - Re: [GIT PULL] x86/vdso changes for v3.1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 25 Aug 2011 15:16:36 -0400
From:	Andrew Lutomirski <luto@....edu>
To:	Arnaud Lacombe <lacombar@...il.com>
Cc:	Ingo Molnar <mingo@...e.hu>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	linux-kernel@...r.kernel.org, "H. Peter Anvin" <hpa@...or.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [GIT PULL] x86/vdso changes for v3.1

On Thu, Aug 25, 2011 at 10:06 AM, Arnaud Lacombe <lacombar@...il.com> wrote:
> On Thu, Aug 25, 2011 at 7:51 AM, Andrew Lutomirski <luto@....edu> wrote:
>> On Thu, Aug 25, 2011 at 1:58 AM, Arnaud Lacombe <lacombar@...il.com> wrote:
>>> Hi,

>>>
>>> commit 59e97e4d6fbcd5b74a94cb48bcbfc6f8478a5e93
>>> Author: Andy Lutomirski <luto@....edu>
>>> Date:   Wed Jul 13 09:24:10 2011 -0400
>>>
>>>    x86: Make alternative instruction pointers relative
>>>
>>>    This save a few bytes on x86-64 and means that future patches can
>>>    apply alternatives to unrelocated code.
>>>
>>>    Signed-off-by: Andy Lutomirski <luto@....edu>
>>>    Link: http://lkml.kernel.org/r/ff64a6b9a1a3860ca4a7b8b6dc7b4754f9491cd7.1310563276.git.luto@mit.edu
>>>    Signed-off-by: H. Peter Anvin <hpa@...ux.intel.com>
>>>
>>
>> I probably missed a hardcoded alternative entry that depends on
>> config.  Can you send me your System.map and the output of objdump -s
>> -j .altinstructions vmlinux?
>>
> see attached.
>
>> I'm also having issues building from your .config.  Building
>> 59e97e4d6fbcd5b74a94cb48bcbfc6f8478a5e93 asks me about Moorestown MID
>> platform, Ethernet, etc.
>>
> yes, the config is against -rc3. An `oldnoconfig' should do the job
> before the build.
>

I still can't reproduce this.  I'm building the attached .config on
the v3.1-rc3, running make ARCH=i386 oldnoconfig (which spews a lot of
changes), then building with ARCH=i386 and test-booting in KVM.   No
panic.

Can you either send me a real .config and exact commit that you're
building or try the attached patch and tell me what it says?

Thanks,
Andy

View attachment "alternative_trace.diff" of type "text/x-patch" (1537 bytes)