linux-kernel - Re: [PATCH] Fix missing 'cnt' in ?: in dmatest

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 25 Aug 2011 15:55:23 -0700
From:	Dan Williams <dan.j.williams@...el.com>
To:	Al Viro <viro@...iv.linux.org.uk>
Cc:	"Dr. David Alan Gilbert" <linux@...blig.org>,
	linux-kernel@...r.kernel.org, nicolas.ferre@...el.com,
	akpm@...ux-foundation.org
Subject: Re: [PATCH] Fix missing 'cnt' in ?: in dmatest

On Sat, Aug 20, 2011 at 6:12 PM, Al Viro <viro@...iv.linux.org.uk> wrote:
> On Sun, Aug 21, 2011 at 01:50:31AM +0100, Dr. David Alan Gilbert wrote:
>
>> (WTH is x=y?:z legal C anyway?)
>
> gccism.  It's not legal C; it's a gcc extension, and not a pretty one at
> that.  It's almost definitely a bug in this case - what used to be in the
> tree is equivalent to cnt > 0 ? cnt > 0 : 0, i.e. cnt > 0 ? 1 : 0, i.e.
> cnt > 0.  AFAICS, after your patch it does make sense.
>
>> Signed-off-by: Dr. David Alan Gilbert <linux@...blig.org>

Thanks, I'll take this through the async_tx.git tree.

--
Dan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/