| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Fri, 26 Aug 2011 13:54:19 -0700
From: Junio C Hamano <gitster@...ox.com>
To: Linus Torvalds <torvalds@...ux-foundation.org>
Cc: Boaz Harrosh <bharrosh@...asas.com>,
Andrew Morton <akpm@...ux-foundation.org>,
Git Mailing List <git@...r.kernel.org>,
linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] .gitattributes: Enable cpp diff parsing for .[ch] files
Linus Torvalds <torvalds@...ux-foundation.org> writes:
> On Thu, Aug 25, 2011 at 3:37 PM, Boaz Harrosh <bharrosh@...asas.com> wrote:
>>
>> Add a .gitattributes file to the Linux tree to enable cpp parsing
>> of the source files.
>
> Hmm. I'm not entirely conviced. If people really think that the hunk
> description matters that much, maybe we should just instead improve on
> the automatic diff detection, and extend it from just binary-vs-text,
> to also do the common hunk-headers.
>
> After all, not having a diff pattern already *does* mean "automatic",
> so it would be just a rather trivial extension to that.
Not quite sure what you exactly mean by "extend it from just binary-vs-text".
Do you mean update buffer_is_binary() and add source language detection?
See also:
http://thread.gmane.org/gmane.comp.version-control.git/180103/focus=180113
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists