linux-kernel - RE: [PATCH 44/46] Staging: hv: vmbus: Fix checkpatch warnings in connection.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 30 Aug 2011 17:03:57 +0000
From:	KY Srinivasan <kys@...rosoft.com>
To:	Joe Perches <joe@...ches.com>
CC:	"gregkh@...e.de" <gregkh@...e.de>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"devel@...uxdriverproject.org" <devel@...uxdriverproject.org>,
	"virtualization@...ts.osdl.org" <virtualization@...ts.osdl.org>,
	Haiyang Zhang <haiyangz@...rosoft.com>
Subject: RE: [PATCH 44/46] Staging: hv: vmbus: Fix checkpatch warnings in
 connection.c



> -----Original Message-----
> From: Joe Perches [mailto:joe@...ches.com]
> Sent: Sunday, August 28, 2011 2:57 AM
> To: KY Srinivasan
> Cc: gregkh@...e.de; linux-kernel@...r.kernel.org;
> devel@...uxdriverproject.org; virtualization@...ts.osdl.org; Haiyang Zhang
> Subject: Re: [PATCH 44/46] Staging: hv: vmbus: Fix checkpatch warnings in
> connection.c
> 
> On Sat, 2011-08-27 at 11:31 -0700, K. Y. Srinivasan wrote:
> > Fix checkpatch warnings in connection.c.
> []
> > diff --git a/drivers/staging/hv/connection.c b/drivers/staging/hv/connection.c
> []
> > @@ -220,11 +220,11 @@ static void process_chn_event(u32 relid)
> >  	channel = relid2channel(relid);
> >
> >  	spin_lock_irqsave(&channel->inbound_lock, flags);
> > -	if (channel && (channel->onchannel_callback != NULL)) {
> > +	if (channel && (channel->onchannel_callback != NULL))
> 
> Useless test for channel or bad placement for spin_lock.
> channel has already been dereferenced by the spin_lock.
> 
> 
Thanks Joe. I will fix this up.

Regards,

K. Y