lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Mon, 29 Aug 2011 22:36:32 -0700
From:	"H. Peter Anvin" <hpa@...or.com>
To:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
CC:	Vivien Didelot <vivien.didelot@...oirfairelinux.com>,
	x86@...nel.org,
	Jerome Oufella <jerome.oufella@...oirfairelinux.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>, linux-kernel@...r.kernel.org
Subject: Re: [v2 2/4] platform: (TS-5500) add GPIO support

On 08/29/2011 03:11 PM, Mark Brown wrote:
> On Fri, Aug 26, 2011 at 07:40:25PM -0400, Vivien Didelot wrote:
> 
>>  arch/x86/platform/ts5500/ts5500_gpio.c |  421 ++++++++++++++++++++++++++++++++
>>  arch/x86/platform/ts5500/ts5500_gpio.h |   60 +++++
> 
> New GPIO drivers should really go under drivers/gpiolib and be called
> gpio-foo.c.
> 

Should they?  It seems a lot more reasonable to have them collected by
platform than by type of device (GPIO), *unless* they are shared.

	-hpa
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists