linux-kernel - [PATCH 1/2] perf sort: Improve dso sort output by separating unresolved samples by type

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 31 Aug 2011 11:49:44 +1000
From:	Anton Blanchard <anton@...ba.org>
To:	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Paul Mackerras <paulus@...ba.org>, Ingo Molnar <mingo@...e.hu>,
	Arnaldo Carvalho de Melo <acme@...stprotocols.net>,
	Frederic Weisbecker <fweisbec@...il.com>, emunson@...bm.net,
	imunsie@....ibm.com
Cc:	linux-kernel@...r.kernel.org
Subject: [PATCH 1/2] perf sort: Improve dso sort output by separating
 unresolved samples by type


We currently roll up all unresolved kernel, user, hypervisor and guest
samples into the one bucket:

    59.64%  [unknown]         
    22.71%  [kernel.kallsyms] 
     9.40%  libj9jit26.so     

We can get a much better high level view by separating these unresolved
samples by symbol type:

    56.64%  [unknown:.]       
    22.71%  [kernel.kallsyms] 
     9.40%  libj9jit26.so     
     2.81%  [unknown:H]       

Signed-off-by: Anton Blanchard <anton@...ba.org>
---

Index: linux-2.6-tip/tools/perf/util/sort.c
===================================================================
--- linux-2.6-tip.orig/tools/perf/util/sort.c	2011-08-31 11:34:53.070439428 +1000
+++ linux-2.6-tip/tools/perf/util/sort.c	2011-08-31 11:37:57.543628167 +1000
@@ -111,6 +111,9 @@ sort__dso_cmp(struct hist_entry *left, s
 	struct dso *dso_r = right->ms.map ? right->ms.map->dso : NULL;
 	const char *dso_name_l, *dso_name_r;
 
+	if (!dso_l && !dso_r)
+		return right->level - left->level;
+
 	if (!dso_l || !dso_r)
 		return cmp_null(dso_l, dso_r);
 
@@ -128,13 +131,16 @@ sort__dso_cmp(struct hist_entry *left, s
 static int hist_entry__dso_snprintf(struct hist_entry *self, char *bf,
 				    size_t size, unsigned int width)
 {
+	char unknown[] = "[unknown:.]";
+
 	if (self->ms.map && self->ms.map->dso) {
 		const char *dso_name = !verbose ? self->ms.map->dso->short_name :
 						  self->ms.map->dso->long_name;
 		return repsep_snprintf(bf, size, "%-*s", width, dso_name);
 	}
 
-	return repsep_snprintf(bf, size, "%-*s", width, "[unknown]");
+	unknown[strlen(unknown) - 2] = self->level;
+	return repsep_snprintf(bf, size, "%-*s", width, unknown);
 }
 
 struct sort_entry sort_dso = {
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/