linux-kernel - Re: [patch v2 05/35] Hexagon: Add syscalls

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 31 Aug 2011 15:34:50 +0200
From:	Arnd Bergmann <arnd@...db.de>
To:	Richard Kuo <rkuo@...eaurora.org>
Cc:	linux-kernel@...r.kernel.org, linux-hexagon@...r.kernel.org
Subject: Re: [patch v2 05/35] Hexagon: Add syscalls

On Tuesday 30 August 2011, Richard Kuo wrote:
> +/*
> + * Many archictures support both sys_mmap and sys_mmap2, which use
> + * a common do_mmap2 function to do the work.  So long as we support
> + * only mmap2, we do it all in-line here.
> + */
> +asmlinkage int sys_mmap2(unsigned long addr, size_t len, unsigned long prot,
> +                        unsigned long flags, unsigned long fd,
> +                        unsigned long pgoff)
> +{

> +}
> +
> +/*  apparently this should only map on page boundaries  */
> +asmlinkage int sys_mmap(unsigned long addr, size_t len,
> +                       unsigned long prot, unsigned long flags,
> +                       unsigned long fd, off_t off)

The first comment doesn't make sense when you have the seconf function
as well. I thought I had commented that you should not provide either one
anyway and just use sys_mmap_pgoff() directly, like openrisc does.

It would probably be useful to change asm-generic/unistd.h to do that by
default, and change the architectures that still use mmap2 with
asm-generic/unistd.h to do a manual override.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/