linux-kernel - Re: [PATCH v1 00/16] ext4: Add metadata checksumming

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 4 Sep 2011 19:44:55 +0200
From:	"Andi Kleen" <andi@...stfloor.org>
To:	"Martin K. Petersen" <martin.petersen@...cle.com>
Cc:	"Andi Kleen" <andi@...stfloor.org>,
	"Martin K. Petersen" <martin.petersen@...cle.com>,
	djwong@...ibm.com, "Greg Freemyer" <greg.freemyer@...il.com>,
	"Andreas Dilger" <adilger.kernel@...ger.ca>,
	"Theodore Tso" <tytso@....edu>,
	"Sunil Mushran" <sunil.mushran@...cle.com>,
	"Amir Goldstein" <amir73il@...il.com>,
	"linux-kernel" <linux-kernel@...r.kernel.org>,
	"Mingming Cao" <cmm@...ibm.com>,
	"Joel Becker" <jlbec@...lplan.org>,
	"linux-fsdevel" <linux-fsdevel@...r.kernel.org>,
	linux-ext4@...r.kernel.org, "Coly Li" <colyli@...il.com>
Subject: Re: [PATCH v1 00/16] ext4: Add metadata checksumming

>>>>>> "Andi" == Andi Kleen <andi@...stfloor.org> writes:
>
>>> On Westmere and beyond it is possible to accelerate generic CRC
>>> calculation using the PCLMULQDQ operation. There are many of our CRC
>
> Andi> Faster than the lookup table? That's hard to believe.
>
> Using PCLMULQDQ you can parallelize the calculation. You can even boost
> hw CRC32C performance that way.
>
>   http://download.intel.com/design/intarch/papers/323405.pdf
>
>   http://download.intel.com/design/intarch/papers/323102.pdf

Doesn't have any performance numbers.

You need to keep in mind that PCLMULQDQ uses FPU state, so any
speedup for the kernel must be large enough to amortize the cost of
saving the FPU state.

Typically that only works out for quite large buffers, but
kernel buffers are relatively small.

For the ext4 metadata a better approach is probably some sort of
incremental CRC, or possibly separate CRCs for very commonly
changed fields. When I looked at this most changes were only for
small fields.

-Andi

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/