linux-kernel - Re: [PATCH v2] cfq: queued/in

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 5 Sep 2011 12:37:04 +0400
From:	Maxim Patlasov <maxim.patlasov@...il.com>
To:	Jens Axboe <axboe@...nel.dk>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] cfq: queued/in_driver stats

Jens,

>> The patch implements gathering and exporting statistics for cfqd->rq_queued
>> and cfqd->rq_in_driver. Average values of queued/in_driver are visible via
>> ...
> Seems like an awful lot of code for something that could be gleaned
> with blktrace?

I agree, from the view of keeping code simple, it's simpler to extend
existing blktrace logging like this:

-	cfq_log_cfqq(cfqd, RQ_CFQQ(rq), "activate rq, drv=%d",
-		     cfqd->rq_in_driver);
+	cfq_log_cfqq(cfqd, RQ_CFQQ(rq), "activate rq, drv=%d queued=%d",
+		     cfqd->rq_in_driver, cfqd->rq_queued);

and to print cfqd->hw_tag somewhere.

Thanks,
Maxim
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/