linux-kernel - Re: Blockers on IIO usage of regmap.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 6 Sep 2011 10:54:39 -0700
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	Jonathan Cameron <jic23@....ac.uk>
Cc:	LKML <linux-kernel@...r.kernel.org>
Subject: Re: Blockers on IIO usage of regmap.

On Tue, Sep 06, 2011 at 12:14:48PM +0100, Jonathan Cameron wrote:

> Just a quick heads up that the big blocker for
> us making more use of regmap is lack of default
> control of cs_change for spi buses.  That leads to

Looking at what you've got here there's nothing interesting with /CS
here, it's all about the data formatting.  Certainly you've not
mentioned anything odd with /CS in any of the code.

> TX  Add0...Add7 XXXXXXXXXXX  XXXXXXXXXXX  XXXXXXXX
> RX  XXXXXXXXXXX Da0.....Da7  Db0.....Db7  etc

This is the standard one that most things do so is already supported.

> TX  Add0...Add7 XXXXXXXXXXX  XXXXXXXXXXX  XXXXXXXXXX
> RX  XXXXXXXXXXX XXXXXXXXXXX  Da0.....Da7  Db0....Db7

This is just inserting a delay so should be trivial to implement and
doesn't even look terribly SPI specific, just set a flag and it should
be fine.  All we need here is someone to actually implement it.  I guess
the delay will be OK for any read?

> TX  Ada0...Ada7  Adb1...Adb7 Adc1...Adc7  etc
> RX  XXXXXXXXXXX  Da0.....Da7 Db0.....Db7  etc

This one is much more of a contortion to implement - it's pretty SPI
specific to stream the register addresses and it's really not what the
system is set up for.  On the other hand if you can come up with a
taseful way to implement it then I don't see a problem.

> So basically we need some bus specific 'mode' hook somewhere.
> Given we have separate init functions for the buses could we
> add a struct regmap_spi_config to the parameter list?

Or just embed stuff into the main config structure at least for the
delay.  Nothing there seems too outrageous, and the delay sounds like
something someone might do on other buses (the delay will be to allow
time for the ADCs or whatever to set up).
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/