linux-kernel - Re: [alsa-devel] [PATCH] ASoC: omap: convert per-board modules to platform drivers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 8 Sep 2011 18:36:43 +0100
From:	Mans Rullgard <mans.rullgard@...aro.org>
To:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
Cc:	Lars-Peter Clausen <lars@...afoo.de>, linux-omap@...r.kernel.org,
	alsa-devel@...a-project.org, Russell King <linux@....linux.org.uk>,
	Tony Lindgren <tony@...mide.com>, linux-kernel@...r.kernel.org,
	Takashi Iwai <tiwai@...e.de>, linaro-dev@...ts.linaro.org,
	Liam Girdwood <lrg@...com>,
	linux-arm-kernel@...ts.infradead.org
Subject: Re: [alsa-devel] [PATCH] ASoC: omap: convert per-board modules to
 platform drivers

On 8 September 2011 17:37, Mark Brown
<broonie@...nsource.wolfsonmicro.com> wrote:
> On Thu, Sep 08, 2011 at 04:41:30PM +0100, Mans Rullgard wrote:
>> On 8 September 2011 16:15, Lars-Peter Clausen <lars@...afoo.de> wrote:
>
>> > Use different device driver names for different drivers.
>
>> I guess this worked by accident on my system.
>
>> Are there any other changes needed?
>
> Check the N810 code - it looks like that driver should be taking
> platform data to distinguish between the two models.  Possibly also rx51
> though I only looked at the diff.  Also it should probably be grabbing
> the clocks before it registers the card.

I don't see any what would need to distinguish models.  The current code
is not doing anything like that.  If it should, that's a separate issue.
Agree on the clocks for N810.

-- 
Mans Rullgard
Multimedia
mans.rullgard@...aro.org
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/