linux-kernel - Re: [PATCH] usb gadget: clean up files

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 09 Sep 2011 15:01:58 +0200
From:	"Michal Nazarewicz" <mina86@...a86.com>
To:	balbi@...com, gregkh@...e.de,
	"Klaus Schwarzkopf" <schwarzkopf@...sortherm.de>
Cc:	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] usb gadget: clean up files

On Fri, 09 Sep 2011 14:52:17 +0200, Klaus Schwarzkopf  
<schwarzkopf@...sortherm.de> wrote:

> remove the following two paragraphs:
>
> This program is distributed in the hope that it will be useful, but
> WITHOUT ANY WARRANTY; without even the implied warranty of  
> MERCHANTABILITY or
> FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public
> License for more details.
>
> You should have received a copy of the GNU General Public License along  
> with
> this program; if not, write to the Free Software Foundation, Inc.,59
> Temple Place - Suite 330, Boston, MA  02111-1307, USA.

I'd add some justification.  Ie. the fact that the address is no longer  
valid.

> Signed-off-by: Klaus Schwarzkopf <schwarzkopf@...sortherm.de>

> diff --git a/drivers/usb/gadget/amd5536udc.c  
> b/drivers/usb/gadget/amd5536udc.c
> index 95e8138..e5802a0 100644
> --- a/drivers/usb/gadget/amd5536udc.c
> +++ b/drivers/usb/gadget/amd5536udc.c
> @@ -9,14 +9,6 @@
>   * the Free Software Foundation; either version 2 of the License, or
>   * (at your option) any later version.
>   *

You've left the sole empty line.  Applies to some other files as well.

> - * This program is distributed in the hope that it will be useful,
> - * but WITHOUT ANY WARRANTY; without even the implied warranty of
> - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> - * GNU General Public License for more details.
> - *
> - * You should have received a copy of the GNU General Public License
> - * along with this program; if not, write to the Free Software
> - * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA   
> 02111-1307  USA
>   */
> /*

> diff --git a/drivers/usb/gadget/epautoconf.c  
> b/drivers/usb/gadget/epautoconf.c
> index 9b7360f..cff842e 100644
> --- a/drivers/usb/gadget/epautoconf.c
> +++ b/drivers/usb/gadget/epautoconf.c
> @@ -8,14 +8,7 @@
>   * the Free Software Foundation; either version 2 of the License, or
>   * (at your option) any later version.
>   *
> - * This program is distributed in the hope that it will be useful,
> - * but WITHOUT ANY WARRANTY; without even the implied warranty of
> - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> - * GNU General Public License for more details.
> - *
> - * You should have received a copy of the GNU General Public License
> - * along with this program; if not, write to the Free Software
> - * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA   
> 02111-1307  USA
> +

Something fishy going on here.  Why empty line?

>   *
>   */

-- 
Best regards,                                         _     _
.o. | Liege of Serenely Enlightened Majesty of      o' \,=./ `o
..o | Computer Science,  Michal "mina86" Nazarewicz    (o o)
ooo +-----<email/xmpp: mnazarewicz@...gle.com>-----ooO--(_)--Ooo--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/