lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 10 Sep 2011 14:22:22 +0000 From: KY Srinivasan <kys@...rosoft.com> To: Greg KH <greg@...ah.com> CC: "gregkh@...e.de" <gregkh@...e.de>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, "devel@...uxdriverproject.org" <devel@...uxdriverproject.org>, "virtualization@...ts.osdl.org" <virtualization@...ts.osdl.org>, Haiyang Zhang <haiyangz@...rosoft.com> Subject: RE: [PATCH 10/25] Staging: hv: vmbus: Return proper error code in vmbus_remove() > -----Original Message----- > From: Greg KH [mailto:greg@...ah.com] > Sent: Friday, September 09, 2011 4:43 PM > To: KY Srinivasan > Cc: gregkh@...e.de; linux-kernel@...r.kernel.org; > devel@...uxdriverproject.org; virtualization@...ts.osdl.org; Haiyang Zhang > Subject: Re: [PATCH 10/25] Staging: hv: vmbus: Return proper error code in > vmbus_remove() > > On Thu, Sep 08, 2011 at 07:24:21AM -0700, K. Y. Srinivasan wrote: > > Return proper error code in vmbus_remove(). > > > > Signed-off-by: K. Y. Srinivasan <kys@...rosoft.com> > > Signed-off-by: Haiyang Zhang <haiyangz@...rosoft.com> > > --- > > drivers/staging/hv/vmbus_drv.c | 4 ++-- > > 1 files changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/staging/hv/vmbus_drv.c b/drivers/staging/hv/vmbus_drv.c > > index b9aeb76..95d33a4 100644 > > --- a/drivers/staging/hv/vmbus_drv.c > > +++ b/drivers/staging/hv/vmbus_drv.c > > @@ -325,7 +325,7 @@ static int vmbus_probe(struct device *child_device) > > */ > > static int vmbus_remove(struct device *child_device) > > { > > - int ret; > > + int ret = 0; > > As remove functions can't fail, why return anything at all? > > Doesn't make sense, please fix. Greg, Looking at the struct bus_type, the remove function is not a void function. I was just fixing something that was broken in this function. Regards, K. Y -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists