linux-kernel - Re: [PATCH 1/2] arm: omap: usb: enable I/O wakeups of ehci and ohci hwmods of omap4

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 12 Sep 2011 12:06:31 +0530
From:	"Munegowda, Keshava" <keshava_mgowda@...com>
To:	Kevin Hilman <khilman@...com>
Cc:	linux-usb@...r.kernel.org, linux-omap@...r.kernel.org,
	linux-kernel@...r.kernel.org, balbi@...com, gadiyar@...com,
	sameo@...ux.intel.com, parthab@...ia.ti.com, tony@...mide.com,
	b-cousson@...com, paul@...an.com, johnstul@...ibm.com,
	vishwanath.bs@...com, Kishon Vijay Abraham <kishon@...com>
Subject: Re: [PATCH 1/2] arm: omap: usb: enable I/O wakeups of ehci and ohci
 hwmods of omap4

On Fri, Sep 9, 2011 at 11:57 PM, Kevin Hilman <khilman@...com> wrote:
> Keshava Munegowda <keshava_mgowda@...com> writes:
>
>> From: Kishon Vijay Abraham <kishon@...com>
>>
>> For ehci and ohci hwmods, the omap4 I/O wakeup capablity is enabled.
>> for ehci in phy mode,
>>       - the DAT0 and DIR I/O pad is set as wakeup capable
>> for ohci in serial mode
>>       - usbb*_mm_rxdp is set as I/O wakeup for 6 pin serial mode
>>       - usbb*_mm_rxrcv is set as I/O wakeup for 4 pin serial mode
>>       - usbb*_mm_txen is set as I/O wakeup for 3 pin serial mode
>>       - usbb*_mm_txdat is set as I/O wakeup for 2 pin serial mode
>>
>> Signed-off-by: Kishon Vijay Abraham <kishon@...com>
>> Signed-off-by: Keshava Munegowda <keshava_mgowda@...com>
>
> What if the end user doesn't want this device to be a wakeup source?
>
> Currently, the IO pad wakeup for these pins is enabled unconditionally.
> While having it enabled as a wakeup source by default is fine, it should
> not generate wakeups if the user has disable them by doing:
>
>    $ echo disabled > /sys/devices/.../power/wakeup

OK, I will do this.

keshava
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/