linux-kernel - Re: [PATCH v2] ALSA: aoa: Remove obsolete cleanup for clientdata

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 12 Sep 2011 13:58:57 +0200
From:	Takashi Iwai <tiwai@...e.de>
To:	Axel Lin <axel.lin@...il.com>
Cc:	linux-kernel@...r.kernel.org,
	Johannes Berg <johannes@...solutions.net>,
	Wolfram Sang <w.sang@...gutronix.de>,
	Jaroslav Kysela <perex@...ex.cz>, alsa-devel@...a-project.org
Subject: Re: [PATCH v2] ALSA: aoa: Remove obsolete cleanup for clientdata

At Fri, 09 Sep 2011 19:04:45 +0800,
Axel Lin wrote:
> 
> The i2c core will clear the clientdata pointer automatically.
> We don't have to set the `data' field to NULL in remove() or
> if probe() failed anymore.
> 
> Also remove a unneeded NULL checking for kfree.
> 
> Signed-off-by: Axel Lin <axel.lin@...il.com>
> Reviewed-by: Wolfram Sang <w.sang@...gutronix.de>

Applied now.  Thanks.


Takashi


> ---
>  sound/aoa/codecs/onyx.c |    4 +---
>  1 files changed, 1 insertions(+), 3 deletions(-)
> 
> diff --git a/sound/aoa/codecs/onyx.c b/sound/aoa/codecs/onyx.c
> index 3687a6c..762af68 100644
> --- a/sound/aoa/codecs/onyx.c
> +++ b/sound/aoa/codecs/onyx.c
> @@ -1067,7 +1067,6 @@ static int onyx_i2c_probe(struct i2c_client *client,
>  	printk(KERN_DEBUG PFX "created and attached onyx instance\n");
>  	return 0;
>   fail:
> -	i2c_set_clientdata(client, NULL);
>  	kfree(onyx);
>  	return -ENODEV;
>  }
> @@ -1112,8 +1111,7 @@ static int onyx_i2c_remove(struct i2c_client *client)
>  
>  	aoa_codec_unregister(&onyx->codec);
>  	of_node_put(onyx->codec.node);
> -	if (onyx->codec_info)
> -		kfree(onyx->codec_info);
> +	kfree(onyx->codec_info);
>  	kfree(onyx);
>  	return 0;
>  }
> -- 
> 1.7.4.1
> 
> 
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/