linux-kernel - Re: [PATCH v2] acpi: Fix CPU hot removal problem

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 13 Sep 2011 13:58:03 +0800
From:	"canquan.shen" <shencanquan@...wei.com>
To:	len.brown@...el.com
Cc:	Bjorn Helgaas <bhelgaas@...gle.com>,
	"shemminger@...tta.com" <shemminger@...tta.com>,
	"yakui.zhao@...el.com" <yakui.zhao@...el.com>,
	"xiaowei.yang@...wei.com" <xiaowei.yang@...wei.com>,
	hanweidong <hanweidong@...wei.com>, linqiangmin@...wei.com,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-acpi@...r.kernel.org" <linux-acpi@...r.kernel.org>
Subject: Re: [PATCH v2] acpi: Fix CPU hot removal problem

On 2011/9/8 10:39, canquan.shen wrote:
> We run Linux as a guest in Xen environment. When used xen tools
> (xm vcpu-set <n>) to hot add and remove vcpu to and from the guest,
> we encountered the failure on vcpu removal. We found the reason is
> that it didn't go to really remove cpu in the cpu removal code path.
>
> This patch adds acpi_bus_trim in acpi_process_hotplug_notify to fix
> this issue. With this patch, it works fine for us.
>
> Signed-off-by: Canquan Shen <shencanquan@...wei.com>
> ---
> drivers/acpi/processor_driver.c | 5 +++++
> 1 files changed, 5 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/acpi/processor_driver.c
> b/drivers/acpi/processor_driver.c
> index a1c564f..114592f 100644
> --- a/drivers/acpi/processor_driver.c
> +++ b/drivers/acpi/processor_driver.c
> @@ -678,7 +678,11 @@ static void
> acpi_processor_hotplug_notify(acpi_handle handle,
> return;
> }
>
> + if (acpi_bus_trim(device, 1)) {
> + printk(KERN_ERR PREFIX
> + "Removing device failed\n");
> + return;
> + }
> break;
> default:
> ACPI_DEBUG_PRINT((ACPI_DB_INFO,

Hi Len,
     I just see your email in linux-kernel maillist and known that your 
kernel.org email is kaput, so I resend this email to your intel email 
address.

Thanks,
- Canquan Shen

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/