linux-kernel - Re: [PATCH v3 06/11] KVM: MMU: cleanup FNAME(invlpg)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4E707A78.4050603@redhat.com>
Date:	Wed, 14 Sep 2011 12:57:12 +0300
From:	Avi Kivity <avi@...hat.com>
To:	Xiao Guangrong <xiaoguangrong@...fujitsu.com>
CC:	Marcelo Tosatti <mtosatti@...hat.com>,
	LKML <linux-kernel@...r.kernel.org>, KVM <kvm@...r.kernel.org>
Subject: Re: [PATCH v3 06/11] KVM: MMU: cleanup FNAME(invlpg)

On 09/13/2011 09:31 PM, Xiao Guangrong wrote:
> >>  @@ -675,36 +684,20 @@ static void FNAME(invlpg)(struct kvm_vcpu *vcpu, gva_t gva)
> >>
> >>            sp = page_header(__pa(sptep));
> >>            if (is_last_spte(*sptep, level)) {
> >>  -            int offset, shift;
> >>  -
> >>                if (!sp->unsync)
> >>                    break;
> >>
> >>  -            shift = PAGE_SHIFT -
> >>  -                  (PT_LEVEL_BITS - PT64_LEVEL_BITS) * level;
> >>  -            offset = sp->role.quadrant<<   shift;
> >>  -
> >>  -            pte_gpa = (sp->gfn<<   PAGE_SHIFT) + offset;
> >>  +            pte_gpa = FNAME(get_first_pte_gpa)(sp);
> >
> >
> >  Here is can be used for L2 - I think we can use 2MB host pages to back 4MB guest mappings.
> >
>
> Only unsync shadow page is fetched here, and its level is always 1.
>

Right.

-- 
error compiling committee.c: too many arguments to function

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/