linux-kernel - Re: [PATCH] cfs: NULL pointer check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 16 Sep 2011 00:42:41 -0700
From:	Paul Turner <pjt@...gle.com>
To:	Wang Xingchao <xingchao.wang@...el.com>
CC:	linux-kernel@...r.kernel.org, mingo@...e.hu, peterz@...radead.org,
	yong.zhang0@...il.com, alex.shi@...el.com
Subject: Re: [PATCH] cfs: NULL pointer check

On 09/16/11 10:48, Wang Xingchao wrote:
> se maybe NULL if cfs_rq->rb_leftmost is NULL

nack, it had better not be; otherwise we've got a corrupt tree!

Also, this diff is against the previous -- please bundle dependent 
patches as a series in the future.

Thanks,

- Paul


>
> Signed-off-by: Wang Xingchao<xingchao.wang@...el.com>
> ---
>   kernel/sched_fair.c |    4 ++++
>   1 files changed, 4 insertions(+), 0 deletions(-)
>
> diff --git a/kernel/sched_fair.c b/kernel/sched_fair.c
> index fef0bfd..109b232 100644
> --- a/kernel/sched_fair.c
> +++ b/kernel/sched_fair.c
> @@ -1130,6 +1130,10 @@ check_preempt_tick(struct cfs_rq *cfs_rq, struct sched_entity *curr)
>   		return;
>
>   	se = __pick_first_entity(cfs_rq);
> +
> +	if (!se)
> +		return;
> +
>   	delta = curr->vruntime - se->vruntime;
>
>   	if (delta<  0)

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/