linux-kernel - [PATCH] squashfs : devblksize set to 4KB intead of BLOCK

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Mon, 19 Sep 2011 00:24:52 +0900
From:	Namjae Jeon <linkinjeon@...il.com>
To:	phillip@...ashfs.org.uk
Cc:	linux-kernel@...r.kernel.org, Namjae Jeon <linkinjeon@...il.com>
Subject: [PATCH] squashfs : devblksize set to 4KB intead of BLOCK_SIZE(1KB).

If devblksize is set by NAND page size before, I think that it is changed to optimal vaule with increasing physical page size of NAND.
So I suggest that devblksize is set to 4KB. it is suitable for physical page size of NAND(onenand, flexonenand etc..) and the minimal compressed size.
and user gain improved performance(~%20) and stop reading inefficiently several time by page alignment.

Signed-off-by: Namjae Jeon <linkinjeon@...il.com>
---
 fs/squashfs/squashfs_fs.h |    3 +++
 fs/squashfs/super.c       |    2 +-
 2 files changed, 4 insertions(+), 1 deletions(-)

diff --git a/fs/squashfs/squashfs_fs.h b/fs/squashfs/squashfs_fs.h
index b4a4e53..c667921 100644
--- a/fs/squashfs/squashfs_fs.h
+++ b/fs/squashfs/squashfs_fs.h
@@ -32,6 +32,9 @@
 #define SQUASHFS_METADATA_SIZE		8192
 #define SQUASHFS_METADATA_LOG		13

+/* size of device blocks */
+#define SQUASHFS_DEVBLK_SIZE		4096
+
 /* default size of data blocks */
 #define SQUASHFS_FILE_SIZE		131072
 #define SQUASHFS_FILE_LOG		17
diff --git a/fs/squashfs/super.c b/fs/squashfs/super.c
index 7438850..2da1715 100644
--- a/fs/squashfs/super.c
+++ b/fs/squashfs/super.c
@@ -95,7 +95,7 @@ static int squashfs_fill_super(struct super_block *sb, void *data, int silent)
 	}
 	msblk = sb->s_fs_info;

-	msblk->devblksize = sb_min_blocksize(sb, BLOCK_SIZE);
+	msblk->devblksize = sb_min_blocksize(sb, SQUASHFS_DEVBLK_SIZE);
 	msblk->devblksize_log2 = ffz(~msblk->devblksize);

 	mutex_init(&msblk->read_data_mutex);
-- 
1.7.4.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/