| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Wed, 21 Sep 2011 16:03:49 +0300 From: Péter Ujfalusi <peter.ujfalusi@...com> To: Mark Brown <broonie@...nsource.wolfsonmicro.com> Cc: Samuel Ortiz <samuel.ortiz@...el.com>, Dmitry Torokhov <dtor@...l.ru>, Liam Girdwood <lrg@...com>, alsa-devel@...a-project.org, linux-kernel@...r.kernel.org, Misael Lopez Cruz <misael.lopez@...com> Subject: Re: Re: Re: Re: [PATCH 07/17] ASoC: twl6040: Lower the initial gains On Wednesday 21 September 2011 13:39:31 Mark Brown wrote: > The key problem here is that you sent a change saying "change the > default volume" with no other context in either the changelog or the > code. If you've got code that's actively managing the volume register > while presenting a nice view to the application layer so that the > register value isn't directly seen in the way it is for standard ASoC > controls that's a very different thing to standard code. I'm not going > to remember the details of everything in every CODEC driver. > > > We do have other scenarios covered, but this initialization was missing. > > This resulted that the _first_ playback has pop noise, but all > > subsequent playbacks were fine, since we had the runtime fix for this. > > So what you're doing here is really a bug fix for the ramping code. I will update the commit message, and I'll also put a comment to the code to explain it clearly. -- Péter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists