linux-kernel - Re: [PATCH] ceph/super.c: quiet sparse noise

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 23 Sep 2011 12:06:43 -0700 (PDT)
From:	Sage Weil <sage@...dream.net>
To:	H Hartley Sweeten <hartleys@...ionengravers.com>
cc:	Linux Kernel <linux-kernel@...r.kernel.org>,
	ceph-devel@...r.kernel.org
Subject: Re: [PATCH] ceph/super.c: quiet sparse noise

Applied, thanks!

sage

On Fri, 23 Sep 2011, H Hartley Sweeten wrote:

> Quiet the sparse noise:
> 
> warning: symbol 'create_fs_client' was not declared. Should it be static?
> warning: symbol 'destroy_fs_client' was not declared. Should it be static?
> 
> Signed-off-by: H Hartley Sweeten <hsweeten@...ionengravers.com>
> Cc: Sage Weil <sage@...dream.net>
> ceph-devel@...r.kernel.org
> 
> ---
> 
> diff --git a/fs/ceph/super.c b/fs/ceph/super.c
> index e0a6a06..bbc1b78 100644
> --- a/fs/ceph/super.c
> +++ b/fs/ceph/super.c
> @@ -426,7 +426,7 @@ static int extra_mon_dispatch(struct ceph_client *client, struct ceph_msg *msg)
>  /*
>   * create a new fs client
>   */
> -struct ceph_fs_client *create_fs_client(struct ceph_mount_options *fsopt,
> +static struct ceph_fs_client *create_fs_client(struct ceph_mount_options *fsopt,
>  					struct ceph_options *opt)
>  {
>  	struct ceph_fs_client *fsc;
> @@ -502,7 +502,7 @@ fail:
>  	return ERR_PTR(err);
>  }
>  
> -void destroy_fs_client(struct ceph_fs_client *fsc)
> +static void destroy_fs_client(struct ceph_fs_client *fsc)
>  {
>  	dout("destroy_fs_client %p\n", fsc);
>  
> --
> To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/