linux-kernel - Re: [PATCH] ACPI: check mutex release status

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 26 Sep 2011 20:59:19 +0800
From:	Lin Ming <ming.m.lin@...el.com>
To:	dave@....org
Cc:	Len Brown <lenb@...nel.org>, lkml <linux-kernel@...r.kernel.org>,
	linux-acpi@...r.kernel.org
Subject: Re: [PATCH] ACPI: check mutex release status

On Mon, Sep 26, 2011 at 7:39 PM, Davidlohr Bueso <dave@....org> wrote:
> From: Davidlohr Bueso <dave@....org>
>
> If this is not done we have a bogus ACPI_FAILURE() call.
>
> Signed-off-by: Davidlohr Bueso <dave@....org>
> ---
>  drivers/acpi/acpica/nsload.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/acpi/acpica/nsload.c b/drivers/acpi/acpica/nsload.c
> index 5f7dc69..f3070fd 100644
> --- a/drivers/acpi/acpica/nsload.c
> +++ b/drivers/acpi/acpica/nsload.c
> @@ -115,7 +115,7 @@ acpi_ns_load_table(u32 table_index, struct acpi_namespace_node *node)
>        }
>
>       unlock:
> -       (void)acpi_ut_release_mutex(ACPI_MTX_NAMESPACE);
> +       status = acpi_ut_release_mutex(ACPI_MTX_NAMESPACE);

No,

The status maybe set before the "goto unlock" statement.

Lin Ming

>
>        if (ACPI_FAILURE(status)) {
>                return_ACPI_STATUS(status);
> --
> 1.7.4.1
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/