linux-kernel - Re: [PATCH 07/10] drbd: Remove headers from on-the-wire data structures (struct p

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 27 Sep 2011 11:34:03 +0200
From:	Philipp Reisner <philipp.reisner@...bit.com>
To:	Kyle Moffett <kyle@...fetthome.net>
Cc:	linux-kernel@...r.kernel.org, Jens Axboe <axboe@...nel.dk>,
	drbd-dev@...ts.linbit.com
Subject: Re: [PATCH 07/10] drbd: Remove headers from on-the-wire data structures (struct p_*)

Am Freitag, 23. September 2011, 19:38:15 schrieb Kyle Moffett:
> Hi!
> 
> On Fri, Sep 23, 2011 at 10:31, Philipp Reisner
> 
> <philipp.reisner@...bit.com> wrote:
> > From: Andreas Gruenbacher <agruen@...bit.com>
> > 
> > Signed-off-by: Philipp Reisner <philipp.reisner@...bit.com>
> > Signed-off-by: Lars Ellenberg <lars.ellenberg@...bit.com>
> > ---
> >  drivers/block/drbd/drbd_int.h      |   45 ----------
> >  drivers/block/drbd/drbd_main.c     |   44 +++++-----
> >  drivers/block/drbd/drbd_receiver.c |  171
> > ++++++++++++++++++------------------ drivers/block/drbd/drbd_worker.c  
> > |    2 +-
> 
> This commit is kind of borderline too-big for just a one-line commit
> message.
> 
> It is admittedly very simple (changing the same pointer math in ~50
> places), but it needs a bit more explanation about why it's helpful or
> necessary.
> 
> I *think* it's because the protocol-100 code will use a different-sized
> header, but that needs to be actually explained somewhere.
> 

I updated the patch to carry the following commit message:

Author: Andreas Gruenbacher <agruen@...bit.com>
Date:   Wed Mar 30 12:54:42 2011 +0200

    drbd: Remove headers from on-the-wire data structures (struct p_*)
    
    Prepare the introduction of the protocol 100 headers. The actual protocol
    header is removed for the packet declarations. I.e. allow us to use the
    packets with different headers.
    
    Signed-off-by: Philipp Reisner <philipp.reisner@...bit.com>
    Signed-off-by: Lars Ellenberg <lars.ellenberg@...bit.com>

Best,
 Phil
-- 
: Dipl-Ing Philipp Reisner
: LINBIT | Your Way to High Availability
: Tel: +43-1-8178292-50, Fax: +43-1-8178292-82
: http://www.linbit.com

DRBD(R) and LINBIT(R) are registered trademarks of LINBIT, Austria.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/