linux-kernel - Re: [PATCH] staging: comedi: Added log subjects to printk()s in pcmmio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 27 Sep 2011 17:40:41 +0200
From:	morbid-rsa <morbidrsa@...glemail.com>
To:	Dan Carpenter <dan.carpenter@...cle.com>
Cc:	gregkh@...e.de, abbotti@....co.uk, fmhess@...rs.sourceforge.net,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org,
	morbidrsa@...glemail.com
Subject: Re: [PATCH] staging: comedi: Added log subjects to printk()s in pcmmio

> The KERN_ERR stuff is only supposed to be used at the start of the
> line of output.  (The previous KERN_INFO printk didn't have a new
> line at the end).
>
> All this code needs to be rewritten so each printk() only prints
> one line.  Otherwise you could get messages printed out in the
> middle of other messages and it looks like crap.
>

*args*, sorry for messing it up, I will take care of it.

> This code is trickier than it looks.  Quite a few newbies have run
> into trouble here.  My advice is to start with something that looks
> tricky so at least if you mess up, you were doing something awesome.
> :)
>
> regards,
> dan carpenter
>
>

Thanks for the advice :D

regards,
Johannes
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/