linux-kernel - [PATCH] watchdog: move watchdog_*_all_cpus under CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Fri, 30 Sep 2011 15:12:54 +0400
From:	Vasily Averin <vvs@...allels.com>
To:	<linux-kernel@...r.kernel.org>
CC:	Andrew Morton <akpm@...ux-foundation.org>,
	Vasily Averin <vvs@...ru>
Subject: [PATCH] watchdog: move watchdog_*_all_cpus under CONFIG_SYSCTL

From: Vasily Averin <vvs@...ru>

fixed compilation warnings in case of disabled CONFIG_SYSCTL
kernel/watchdog.c:483:13: warning: ‘watchdog_enable_all_cpus’ defined but not used
kernel/watchdog.c:500:13: warning: ‘watchdog_disable_all_cpus’ defined but not used

these functions are are static and are used only in sysctl handler,
so move them inside #ifdef CONFIG_SYSCTL too

Signed-off-by: Vasily Averin <vvs@...ru>
---
 kernel/watchdog.c |    5 ++---
 1 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/kernel/watchdog.c b/kernel/watchdog.c
index 36491cd..13644ee 100644
--- a/kernel/watchdog.c
+++ b/kernel/watchdog.c
@@ -480,6 +480,8 @@ static void watchdog_disable(int cpu)
 	}
 }
 
+/* sysctl functions */
+#ifdef CONFIG_SYSCTL
 static void watchdog_enable_all_cpus(void)
 {
 	int cpu;
@@ -508,9 +510,6 @@ static void watchdog_disable_all_cpus(void)
 	watchdog_enabled = 0;
 }
 
-
-/* sysctl functions */
-#ifdef CONFIG_SYSCTL
 /*
  * proc handler for /proc/sys/kernel/nmi_watchdog,watchdog_thresh
  */
-- 
1.7.4.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/