linux-kernel - Re: [PATCH] mmc: sdhci-tegra: Add #ifdef CONFIG_OF guard for of_find

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 4 Oct 2011 12:32:32 -0600
From:	Grant Likely <grant.likely@...retlab.ca>
To:	Stephen Warren <swarren@...dia.com>
Cc:	Igor Grinberg <grinberg@...pulab.co.il>,
	Axel Lin <axel.lin@...il.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Chris Ball <cjb@...top.org>, Olof Johansson <olof@...om.net>,
	"linux-mmc@...r.kernel.org" <linux-mmc@...r.kernel.org>
Subject: Re: [PATCH] mmc: sdhci-tegra: Add #ifdef CONFIG_OF guard for
 of_find_property

On Mon, Oct 03, 2011 at 08:59:45AM -0700, Stephen Warren wrote:
> Igor Grinberg wrote at Monday, October 03, 2011 2:32 AM:
> > Hi Axel,
> > 
> > On 10/03/11 06:07, Axel Lin wrote:
> > > I got below build error with "make tegra_defconfig;make"
> > > Add #ifdef CONFIG_OF guard for of_find_property to fix below build error:
> > >
> > >   CC      drivers/mmc/host/sdhci-tegra.o
> > > drivers/mmc/host/sdhci-tegra.c: In function 'sdhci_tegra_dt_parse_pdata':
> > > drivers/mmc/host/sdhci-tegra.c:157: error: implicit declaration of function 'of_find_property'
> ...
> > > diff --git a/drivers/mmc/host/sdhci-tegra.c b/drivers/mmc/host/sdhci-tegra.c
> ...
> > > @@ -154,8 +154,11 @@ static struct tegra_sdhci_platform_data * __devinit sdhci_tegra_dt_parse_pdata(
> > >  	plat->cd_gpio = of_get_named_gpio(np, "cd-gpios", 0);
> > >  	plat->wp_gpio = of_get_named_gpio(np, "wp-gpios", 0);
> > >  	plat->power_gpio = of_get_named_gpio(np, "power-gpios", 0);
> > > +
> > > +#ifdef CONFIG_OF
> > >  	if (of_find_property(np, "support-8bit", NULL))
> > >  		plat->is_8bit = 1;
> > > +#endif
> > 
> > Shouldn't we add a stub for the of_find_property() method to include/linux/of.h
> > instead of adding more ifdefs?
> > Or may be use of_get_property() method instead?
> 
> I submitted a patch to add a stub of_find_property a little while back.
> Per https://lkml.org/lkml/2011/9/22/301, Grant applied it already. I'm
> not sure why it hasn't shown up in linux-next, since Grant's repo wasn't
> affected by the kernel.org downtime.
> 
> Sorry for the breakage.

That's because I forgot to push out the tree.  :-(  Sorry.  I've just
fixed it now.

g.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/