linux-kernel - Re: [PATCH 04/10] Display /proc/stat information per cgroup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 5 Oct 2011 16:10:55 +0400
From:	Glauber Costa <glommer@...allels.com>
To:	Peter Zijlstra <a.p.zijlstra@...llo.nl>
CC:	<linux-kernel@...r.kernel.org>, <paul@...lmenage.org>,
	<lizf@...fujitsu.com>, <daniel.lezcano@...e.fr>,
	<jbottomley@...allels.com>
Subject: Re: [PATCH 04/10] Display /proc/stat information per cgroup

On 10/05/2011 12:56 PM, Peter Zijlstra wrote:
> On Sun, 2011-10-02 at 23:21 +0400, Glauber Costa wrote:
>> +struct kernel_stat *task_group_kstat(struct task_struct *p)
>> +{
>> +       struct task_group *tg;
>> +       struct kernel_stat *kstat;
>> +
>> +       rcu_read_lock();
>> +       tg = task_group(p);
>> +       kstat = tg->cpustat;
>> +       rcu_read_unlock();
>> +       return kstat;
>> +}
>
> Who keeps tg alive and kicking while you poke at its (cpustat) member?

* All calls to this function currently pass current as a parameter 
(Okay, maybe it is too generic and we should pass nothing at all, and 
grab current within it)
* rcu_read_lock() guarantees that current will exist during this call, 
and task_group won't change. (right?)


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/