linux-kernel - Re: [PATCH 4/8] kernel/workqueue.c: unbound work queue rescuer runs on first cpu in cpumask_online

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 5 Oct 2011 20:52:12 +0200 (CEST)
From:	Thomas Gleixner <tglx@...utronix.de>
To:	Fenghua Yu <fenghua.yu@...el.com>
cc:	Ingo Molnar <mingo@...e.hu>, H Peter Anvin <hpa@...or.com>,
	Zwane Mwaikambo <zwane@....linux.org.uk>,
	Tony Luck <tony.luck@...el.com>,
	Asit K Mallick <asit.k.mallick@...el.com>,
	Suresh B Siddha <suresh.b.siddha@...el.com>,
	Len Brown <lenb@...nel.org>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	Peter Zijlstra <peterz@...radead.org>,
	Tejun Heo <tj@...nel.org>
Subject: Re: [PATCH 4/8] kernel/workqueue.c: unbound work queue rescuer runs
 on first cpu in cpumask_online_cpu

On Wed, 5 Oct 2011, Fenghua Yu wrote:

> From: Fenghua Yu <fenghua.yu@...el.com>
> 
> If work queue is unbound to a specific cpu, run rescuer on first cpu in
> cpumask_online_cpu instead BSP which could be offlined.

This patch needs to be applied separate from that series as it fixes a
bug which affects all architectures which can offline the boot cpu.

Thanks,

	tglx

 
> Signed-off-by: Fenghua Yu <fenghua.yu@...el.com>
> ---
>  kernel/workqueue.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/kernel/workqueue.c b/kernel/workqueue.c
> index 1783aab..d26e411 100644
> --- a/kernel/workqueue.c
> +++ b/kernel/workqueue.c
> @@ -1496,9 +1496,9 @@ static bool send_mayday(struct work_struct *work)
>  
>  	/* mayday mayday mayday */
>  	cpu = cwq->gcwq->cpu;
> -	/* WORK_CPU_UNBOUND can't be set in cpumask, use cpu 0 instead */
> +	/* WORK_CPU_UNBOUND can't be set in cpumask, use first cpu instead */
>  	if (cpu == WORK_CPU_UNBOUND)
> -		cpu = 0;
> +		cpu = cpumask_first(cpu_online_mask);
>  	if (!mayday_test_and_set_cpu(cpu, wq->mayday_mask))
>  		wake_up_process(wq->rescuer->task);
>  	return true;
> -- 
> 1.6.0.3
> 
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/