linux-kernel - Re: [RFCv3][PATCH 4/4] show page size in /proc/$pid/numa

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 5 Oct 2011 12:24:24 -0700 (PDT)
From:	David Rientjes <rientjes@...gle.com>
To:	Eric Dumazet <eric.dumazet@...il.com>
cc:	Dave Hansen <dave@...ux.vnet.ibm.com>, linux-mm@...ck.org,
	linux-kernel@...r.kernel.org,
	James.Bottomley@...senpartnership.com, hpa@...or.com
Subject: Re: [RFCv3][PATCH 4/4] show page size in /proc/$pid/numa_maps

On Wed, 5 Oct 2011, Eric Dumazet wrote:

> > How does it break old scripts?
> > 
> 
> Old scripts just parse numa_maps, and on typical machines where
> hugepages are not used, they dont have to care about page size.
> They assume pages are 4KB.
> 
> Adding a new word (pagesize=...) might break them, but personally I dont
> care.
> 

If your script is only parsing numa_maps, then Dave's effort is actually 
allowing them to be fixed rather than breaking them.  We could silently 
continue to export the page counts without specifying the size (hugetlb 
pages are counted in their true hugepage size, THP pages are counted in 
PAGE_SIZE units), but then a script would always be broken unless they use 
smaps as well.  Dave's addition of pagesize allows numa_maps to stand on 
its own and actually be useful when hugepages are used.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/