linux-kernel - Re: [PATCH 1/2] regulator: Fix some bitrot in the machine driver documentation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 5 Oct 2011 18:39:56 -0700
From:	Philip Rakity <prakity@...vell.com>
To:	Liam Girdwood <lrg@...com>
CC:	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	"patches@...nsource.wolfsonmicro.com" 
	<patches@...nsource.wolfsonmicro.com>,
	Mark Brown <broonie@...nsource.wolfsonmicro.com>
Subject: Re: [PATCH 1/2] regulator: Fix some bitrot in the machine driver
 documentation


Resend

Did not make it yet into linux next.


On Sep 8, 2011, at 10:41 AM, Mark Brown wrote:

> The documentation for the machine driver was rather badly bitrotted,
> using pointers to struct device rather than dev_name() to hook up the
> consumers. Update to use dev_name().
> 
> Reported-by: Philip Rakity <prakity@...vell.com>
> Signed-off-by: Mark Brown <broonie@...nsource.wolfsonmicro.com>
> ---
> Documentation/power/regulator/machine.txt |    8 ++++----
> 1 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/Documentation/power/regulator/machine.txt b/Documentation/power/regulator/machine.txt
> index b42419b..311c61f 100644
> --- a/Documentation/power/regulator/machine.txt
> +++ b/Documentation/power/regulator/machine.txt
> @@ -16,7 +16,7 @@ initialisation code by creating a struct regulator_consumer_supply for
> each regulator.
> 
> struct regulator_consumer_supply {
> -	struct device *dev;	/* consumer */
> +	const char *dev_name;	/* consumer dev_name() */
> 	const char *supply;	/* consumer supply - e.g. "vcc" */
> };
> 
> @@ -24,13 +24,13 @@ e.g. for the machine above
> 
> static struct regulator_consumer_supply regulator1_consumers[] = {
> {
> -	.dev	= &platform_consumerB_device.dev,
> -	.supply	= "Vcc",
> +	.dev_name	= "dev_name(consumer B)",
> +	.supply		= "Vcc",
> },};
> 
> static struct regulator_consumer_supply regulator2_consumers[] = {
> {
> -	.dev	= &platform_consumerA_device.dev,
> +	.dev	= "dev_name(consumer A"),
> 	.supply	= "Vcc",
> },};
> 
> -- 
> 1.7.5.4
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/