linux-kernel - Re: [lm-sensors] [PATCH] hwmon class driver registration with a device number

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 6 Oct 2011 22:13:00 +0530
From:	Himanshu Chauhan <hschauhan@...ltrace.org>
To:	Guenter Roeck <guenter.roeck@...csson.com>
Cc:	Jean Delvare <khali@...ux-fr.org>,
	"lm-sensors@...sensors.org" <lm-sensors@...sensors.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [lm-sensors] [PATCH] hwmon class driver registration with a
 device number

On Thu, Oct 06, 2011 at 08:15:26AM -0700, Guenter Roeck wrote:

> Having said that, I realize there are instances where the _minor_ device
> number is passed to the class registration function (eg for misc
> devices). In that case, though, misc_register() checks if the asked for
> minor device already exists, and retains the option to generate a
> dynamic minor device. This is different here, where the proposal is to
> pass both major and minor device number to the registration function.
> 
> Maybe there are instances where both major and minor device number are
> passed; as I mentioned before, I did not spend that much time on it. But
> you are right - that isn't the point anyway.
> 

If misc and other classes can create nodes based on device numbers that
are passed to them, why is it a problem for hwmon? Why does hwmon creates
devices with MKDEV(0,0)? I am still not getting the point.

-Himanshu
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/